Comments on: Ruby: Complexity cannot be reduced

By: » links for 2010-08-25 (Dhananjay Nene)

» links for 2010-08-25 (Dhananjay Nene) — Wed, 25 Aug 2010 20:02:05 +0000

[...] Code Monkeyism: Ruby: Complexity cannot be reduced @dnene Ah here: http://bit.ly/9pyU6I "Ruby: Complexity cannot be reduced" #ruby – Stephan Schmidt (codemonkeyism) http://twitter.com/codemonkeyism/statuses/22063730581 (tags: from:codemonkeyism ruby via:packrati.us) [...]

By: stephan

stephan — Thu, 21 Jun 2007 14:19:05 +0000

Hi afsina, thanks for your comment.

Some thoughts on your comment:

- I usually use JODA or a Calendar (if I have to)

- I wanted to stay close to the Ruby example, as the preface states: “This article contains code examples, which could be written better and which experienced Java and Ruby developers would write differently.”

- As said there is no full code. These were some code example to illustrate the CC points made in the post (“But the examples were chosen to illustrate points”).

By: afsina

afsina — Thu, 21 Jun 2007 14:10:41 +0000

Some thoughts on your java code:

- new Date(1,1,1935) is deprecated. you can use GregorianCalendar instead. Java 7 will have better datetime handlin tough.

- you can use static import for SongType in Java code, it would reduce the code crowd. as: SongType.TRAD_JAZZ -> TRAD_JAZZ

Lastly,

if (song.isMp3Type(Mp3Jazz.class) sounds a little awkward to me. it smells a little but cannot say much before i see the full code.